Updates Jackson usage to use immutable ObjectReader/Writer instead of ObjectMapper #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdemers do you want to rebase? |
|
@bdemers wanna rebase? |
… ObjectMapper Jackson 2.10+ recommend using `ObjectReader` and `ObjectWriter` as opposed to `ObjectMapper` https://cowtowncoder.medium.com/jackson-3-0-immutability-w-builders-d9c532860d88
bdemers
force-pushed
the
jackson-immutable
branch
from
0c55bfc to
decd9c2
Compare
bdemers
commented
Aug 18, 2025
| .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); // https://github.com/jwtk/jjwt/issues/893 | ||
| } | ||
|
|
||
| protected final ObjectMapper objectMapper; |
There was a problem hiding this comment.
I just quickly rebased this, but I want to take another look when I have a few more minutes.
This is a breaking change, the point of this change though is to avoid mutation of the ObjectMapper, but this will require tweaking the change log (mentioning the breaking change, and NOT making this change in a patch release)
There was a problem hiding this comment.
Ah, ok, so gotta wait until 1.0 I suppose.
There was a problem hiding this comment.
And you even specified that milestone! Sorry for the noise 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… ObjectMapper
Jackson 2.10+ recommend using
ObjectReaderandObjectWriteras opposed toObjectMapperhttps://cowtowncoder.medium.com/jackson-3-0-immutability-w-builders-d9c532860d88